search

martinlackner / abcvoting

Python implementations of approval-based committee (multi-winner) voting rules
https://abcvoting.readthedocs.io/
MIT License
32 stars 16 forks source link

Refactor verbose flag to Output() class #41

Closed lumbric closed 3 years ago

lumbric commented 3 years ago

This is a major refactoring with many lines changed, but not so much happening. Every print is replaced by the according call to Output() and if blocks and verbose flags are removed if possible.

Note that due to bugs in the old code, the output of survey and example scripts changed. A unit test test_survey.py was added, so the PR contains also a diff of the output (see 49d4f51bc6e3).

codecov-io commented 3 years ago

Codecov Report

Merging #41 (2c980f5) into master (75887b1) will increase coverage by 0.22%. The diff coverage is 91.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   84.14%   84.37%   +0.22%     
==========================================
  Files          41       42       +1     
  Lines        2858     2983     +125     
  Branches      656      625      -31     
==========================================
+ Hits         2405     2517     +112     
- Misses        386      402      +16     
+ Partials       67       64       -3
Impacted Files Coverage Δ
survey/example09.py 0.00% <0.00%> (ø)
survey/propositionA2.py 0.00% <0.00%> (ø)
tests/test_output.py 76.36% <76.36%> (ø)
tests/test_scripts.py 87.32% <87.32%> (ø)
abcvoting/output.py 94.28% <94.28%> (ø)
abcvoting/abcrules.py 94.45% <95.92%> (+1.28%) :arrow_up:
tests/test_abcrules.py 92.00% <96.29%> (-0.08%) :arrow_down:
abcvoting/abcrules_gurobi.py 13.20% <100.00%> (ø)
examples/simple.py 100.00% <100.00%> (ø)
survey/example02.py 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75887b1...2c980f5. Read the comment docs.