Closed elvic96 closed 2 years ago
@martinlackner latest commit, added function for checking JR, and black-formatted properties.py. Next step would be to add unit tests from literature for correctness, later my own generated tests.
Merging #55 (a1a129a) into master (54d1492) will decrease coverage by
5.07%
. The diff coverage is42.23%
.
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 84.33% 79.26% -5.08%
==========================================
Files 43 44 +1
Lines 3901 4287 +386
Branches 932 1056 +124
==========================================
+ Hits 3290 3398 +108
- Misses 506 781 +275
- Partials 105 108 +3
Impacted Files | Coverage Δ | |
---|---|---|
abcvoting/properties.py | 15.41% <15.41%> (ø) |
|
tests/test_properties.py | 75.13% <75.13%> (ø) |
|
examples/allrules.py | 0.00% <0.00%> (-85.72%) |
:arrow_down: |
abcvoting/genprofiles.py | 83.33% <0.00%> (-5.80%) |
:arrow_down: |
abcvoting/preferences.py | 90.69% <0.00%> (-2.49%) |
:arrow_down: |
tests/test_examples.py | 90.78% <0.00%> (-2.46%) |
:arrow_down: |
abcvoting/abcrules_ortools.py | 85.89% <0.00%> (-0.85%) |
:arrow_down: |
abcvoting/fileio.py | 76.80% <0.00%> (-0.69%) |
:arrow_down: |
abcvoting/abcrules_gurobi.py | 9.95% <0.00%> (-0.63%) |
:arrow_down: |
tests/test_instances/generate.py | 8.73% <0.00%> (-0.18%) |
:arrow_down: |
... and 46 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 54d1492...a1a129a. Read the comment docs.
@elvic96 , thank you very much for your work!
Initial changes to file properties.py made. "Lazy" implementation of check_JR() removed. Commenting should now be more inline with the rest of the code. @martinlackner