martinlackner / abcvoting

Python implementations of approval-based committee (multi-winner) voting rules
https://abcvoting.readthedocs.io/
MIT License
32 stars 16 forks source link

Implement maximin support method (MMS) #65

Closed DominikPeters closed 1 year ago

DominikPeters commented 1 year ago

I've added an implementation of the MMS method. For now, it only includes an implementation based on gurobi, but it should be easily portable to the mip package (because only a small piece of the code lives in abcrules_gurobi). The boilerplate code for the resolute/irresolute implementation is based on the code for sequential Thiele.

codecov-commenter commented 1 year ago

Codecov Report

Merging #65 (c16f9f2) into master (ea152fb) will increase coverage by 0.19%. The diff coverage is 95.04%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   91.19%   91.38%   +0.19%     
==========================================
  Files          11       11              
  Lines        3134     3262     +128     
  Branches      989     1024      +35     
==========================================
+ Hits         2858     2981     +123     
- Misses        162      164       +2     
- Partials      114      117       +3     
Impacted Files Coverage Δ
abcvoting/abcrules_gurobi.py 88.35% <90.00%> (+0.14%) :arrow_up:
abcvoting/abcrules_mip.py 88.31% <90.90%> (+0.43%) :arrow_up:
abcvoting/abcrules.py 93.23% <97.46%> (+0.23%) :arrow_up:

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea152fb...c16f9f2. Read the comment docs.

DominikPeters commented 1 year ago

https://github.com/martinlackner/abcvoting/issues/57