search

martinlackner / abcvoting

Python implementations of approval-based committee (multi-winner) voting rules
https://abcvoting.readthedocs.io/
MIT License
31 stars 15 forks source link

Implement FJR #66

Closed DominikPeters closed 1 year ago

DominikPeters commented 1 year ago

Add checks for Full Justified Representation (brute force and gurobi).

In the process, added some extra property tests (check that logical implications and contrapositives hold on instances).

codecov-commenter commented 1 year ago

Codecov Report

Merging #66 (f20b12d) into master (2da4003) will increase coverage by 0.03%. The diff coverage is 93.54%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   91.24%   91.28%   +0.03%     
==========================================
  Files          11       11              
  Lines        3141     3200      +59     
  Branches      989     1006      +17     
==========================================
+ Hits         2866     2921      +55     
- Misses        161      163       +2     
- Partials      114      116       +2
Impacted Files Coverage Δ
abcvoting/misc.py 87.50% <50.00%> (-1.87%) :arrow_down:
abcvoting/properties.py 95.08% <96.55%> (+0.19%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2da4003...f20b12d. Read the comment docs.