Updating the sampling module to use prefsampling instead of the current functions.

martinlackner / abcvoting

Python implementations of approval-based committee (multi-winner) voting rules

https://abcvoting.readthedocs.io/

MIT License

32 stars 16 forks source link

Updating the sampling module to use prefsampling instead of the current functions. #75

Closed Simon-Rey closed 7 months ago

Simon-Rey commented 8 months ago

Hey!

With the development of prefsampling (https://github.com/COMSOC-Community/prefsampling) I am trying to update sampling procedures of other packages so that they use the samplers provided in prefsampling. This is done to avoid code repetition, mistakes etc...

I could start doing so for abcvoting, any objection before I start? Any requirements?

Simon.

martinlackner commented 8 months ago

Hi Simon!

Sounds like a great idea! Here are a few nice-to-haves:

the function signatures should remain the same (names, parameters)
the unit tests still work ;)
no additional requirements (except pref sampling)

Let me know if you have questions!

Simon-Rey commented 8 months ago

Yeah of course for all of that! Thanks :)

martinlackner commented 7 months ago

Added via PR #78