search

martinlindhe / laravel-vue-i18n-generator

Generates a vue-i18n compatible include file from your Laravel translations
MIT License
306 stars 207 forks source link

Fix lang generation caused by missleading test case #38

Closed roseffendi closed 6 years ago

roseffendi commented 6 years ago

I made a mistake in my previous pull request #37 . My missleading test has caused wrong generation.

This PR fix that problem and also update phpunit dependency to latest version because the phpunit used before has some deprecated function in php 7.2

I've revert back to previous phpunit version but the lock file still require php ^7.0. Apparently it was because "illuminate/support" require "doctrine/inflector": "~1.1" and composer gave "doctrine/inflector": "1.2.0" which is require php ^7.0.

martinlindhe commented 6 years ago

Hi again and thanks for following up :-)

Is the composer.lock changes necessary? It seems they are breaking in travis on some supported php versions at the moment, and reverting these should make it pass again.

martinlindhe commented 6 years ago

Thank you very much for this!