Support for Laravel 5.8

martinlindhe / laravel-vue-i18n-generator

Generates a vue-i18n compatible include file from your Laravel translations

MIT License

306 stars 207 forks source link

Closed voicecode-bv closed 5 years ago

martinlindhe commented 5 years ago

As a rule of thumb it makes sense to separate different changes into different PR:s.

This PR contains

Laravel 5.8 support
Unrelated new feature of disabling output messages (I thought we had this already somewhere, thanks)
Unrelated cosmetic changes

All looks good tho and I'll merge. But for easy cooperation with random people going forward, please consider limiting your PR:s.

voicecode-bv commented 5 years ago

Sorry about that. I noticed it too late. I don't know why the optional output of messages is included again, that was already merged before...

martinlindhe commented 5 years ago

I think because you didn't base your work against the git-master branch.

voicecode-bv commented 5 years ago

Yeah I noticed, I was the one who committed that PR back then. Will pay more attention the next time ;-)

martinlindhe commented 5 years ago

Ah, that makes sense :-)

martinlindhe commented 5 years ago

Resolved with #77