search

martinlindhe / laravel-vue-i18n-generator

Generates a vue-i18n compatible include file from your Laravel translations
MIT License
306 stars 207 forks source link

#56 Extended to generate multiple files per locale #82

Closed rabrowne85 closed 5 years ago

rabrowne85 commented 5 years ago

I had the same requirement as @ngstwr in Issue #56 and have taken a stab at getting this working.

I've run the tests that are built in, but not sure if we need to extend these to catch the new use case. I don't see any tests pertaining to the original --multi flag so didn't have anything I could copy.

I have seen there's another pull-request waiting, so there may be some alterations if this is merged into the source.

Any comments, please let me know.

martinlindhe commented 5 years ago

Looks good and I'm thankful you introduce the new behavior as disabled by default so It should not cause issues for existing users.

I just merged that other PR so this need a rebase first.

rabrowne85 commented 5 years ago

No problems at all. Just rebased the code for you. Looks like all the tests are good and it still works for what I need.

Let me know if there's anything else you need.

martinlindhe commented 5 years ago

Looks all good, thanks for your contribution!

martinlindhe commented 5 years ago

I just pushed out 0.1.38 which contains these changes.