martinlindhe / laravel-vue-i18n-generator

Generates a vue-i18n compatible include file from your Laravel translations
MIT License
306 stars 207 forks source link

Multiple-locales does not include json files #92

Closed murrant closed 5 years ago

murrant commented 5 years ago

My application has both json and php language files. Both are included when I do a single file, but if I add --multiple-locales, json is not included in the output.

martinlindhe commented 5 years ago

Not a bug. This software is used to translate the Laravel translations (PHP files) into JSON for consumption by a js frontend such as vue-i18n

murrant commented 5 years ago

@martinlindhe I am talking about official Laravel translations.

https://laravel.com/docs/localization#using-translation-strings-as-keys

martinlindhe commented 5 years ago

@murrant you are welcome to provide a patch to resolve your issue

murrant commented 5 years ago

I have one that fixes my use case but I wasn't sure what was expected for the multiple files option (which my patch breaks). Tests for these would help.

murrant commented 5 years ago

Fixed by #96