search

martinlindhe / laravel-vue-i18n-generator

Generates a vue-i18n compatible include file from your Laravel translations
MIT License
306 stars 207 forks source link

Allow multiple umd files to load into global.vuei18nLocales #98

Closed murrant closed 4 years ago

murrant commented 4 years ago

Hmm, maybe not use es6 here?

martinlindhe commented 4 years ago

Hmm, maybe not use es6 here?

Yes, this should not use es6.

Also, I'm not sure about the necessity of this feature. What is the use case?

murrant commented 4 years ago

I am loading languages selectively via external template. So just simple:

With existing code, you lose the fallback language (I have many partial translations in my app).

murrant commented 4 years ago

updated to not use es6, I'll update tests if it is ok.

murrant commented 4 years ago

@martinlindhe Anything else needed to get this merged?

martinlindhe commented 4 years ago

LGTM