Closed mbt closed 9 years ago
Hi Michael, thanks for sending this. I've made some comments on the individual commits with some requested changes, please make these and update the pull request if you can.
Will do in just a few minutes. Thanks for the feedback.
OK, just pushed new commits. The net impact is cleaner than the commit history; if desired, I can simply cancel this pull request and create a new one with a cleaner commit history. Otherwise, I think I addressed everything. Let me know!
Hi, thanks for the fixes! I've merged this upstream into the mainline libserialport repo at http://sigrok.org/gitweb/?p=libserialport.git (I've stashed together some of the commits for nicer history indeed).
The DEBUG_FMT fix was already included in mainline so that got dropped, the rest should be in now.
The -no-undefined is indeed needed for shared builds on Windows (DLLs and Import-DLLs), that's a libtool design choice, I think. It won't build DLLs without -no-undefined at all. I've verified that the current state now builds both for shared and static builds (Linux and Windows).
Cheers!
When building for Windows (using MingW on Linux), the build fails for three reasons:
-no-undefined
command-line flag being passed to it. Doesn't make much sense to me, since there are no unresolved symbols, but now the DLL builds with a normal "./configure && make" and no extra settings.These commits allow the mingw-compiled Windows build to work again.