martinmarinov / TempestSDR

Remote video eavesdropping using a software-defined radio platform
GNU General Public License v3.0
1.27k stars 241 forks source link

Optimized loop in read_async() #42

Closed John-Leitch closed 1 year ago

John-Leitch commented 3 years ago

Preliminary tests indicate significant improvement in FPS. May warrant proper benchmarking, but makes enough sense to me. Famous last words, spoken through coconut radio.

xloem commented 3 years ago

@martinmarinov @mgkuhn do either of you have time to glance at this pull request? Seeing that pull requests are merged can inspire visitors to contribute more to projects.

mgkuhn commented 3 years ago

Looks sensible and straight-forward to me, factoring one conditional branch out of an inner loop. (However, I don't currently have a build environment to test it myself locally.) @martinmarinov Shall I click “rebase and merge”?