search

martinmcclure / mist

Filetree code for the Mist project (mist-project.org)
32 stars 5 forks source link

Automate Fog tests #4

Closed timfel closed 11 years ago

timfel commented 12 years ago

These run on Squeak 4.3 and Pharo 1.4 for me

martinmcclure commented 12 years ago

Thanks! This looks great. However, for me in Pharo 1.4 it fails assertions on three of the tests. I'm looking into that. Maybe I'm using the wrong OSProcess configuration? I'm loading OSProcess using this:

Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfOSProcess'; load. (Smalltalk at: #ConfigurationOfOSProcess) project bleedingEdge load.

timfel commented 12 years ago

I just used the OSProcess that comes with the Metacello preview

timfel commented 12 years ago

Which tests are failing for you?

martinmcclure commented 12 years ago

I've pulled your code into the issue4-testauto branch in my repository. Just got back to Portland. I looked into this on the plane -- I think this code is most of the way there but has two remaining issues that I see:

  1. The chmod is being executed in the current working directory, while the files are in the image directory. If these are not the same directory (which they aren't in my setup using the Pharo one-click) the chmod fails and the ELF file cannot be executed. This can most likely be fixed by using a full pathname for the chmod.
  2. Given the above, all the tests should be failing for me. The ones that are passing pass because they attempt to execute the program but do not check the exit code of the program, so they do not know that the execute failed. I'm pretty much completely unfamiliar with OSProcess, but it looks like there is some way to figure out the exit status of a process, so the tests should be able to check that.