search

martinmicunda / ionic-photo-gallery

A hybrid app with authentication that allows registered users view a gallery of photos they have uploaded via the camera phone.
MIT License
174 stars 76 forks source link

Update read.me - dirs #1

Open rpCal opened 9 years ago

rpCal commented 9 years ago

Hi, I find very small thing. I think you should update section "Running App" and change everywhere "cd ionic" to "cd ionic-photo-gallery" and add sudo to "npm install" :) ps. I love this repo! I love the code quality and all work you done. :+1: Thank you for all what you done!

martinmicunda commented 9 years ago

Hi,

Regarding to change cd ionic to cd ionic-photo-gallery the README is correct because assumption is that you are running this project inside of Vagrant (the only problem is that Vagrant doesn't support iOS yet only android platform because of Apple License so you are right that sometimes you have to run ionic app outside of Vagrant and in this case you need to use cd ionic-photo-gallery). The idea was to run all development inside of vagrant (you need to java etc for android platform) so it would be easy to reuse same settings everywhere however that's not fully possible because of Apple license at the moment and my understating is that Ionic team is working to get iOS emulator somehow run inside of Vagrant but I don't know if they have made any progress.

Not sure about sudo command. Have you got any error during running npm install? sudo should be only required for global packages....

P.S.: thanks for feedback ;)