search

martinmoene / expected-dark

Expected objects for C++11 and later (and later perhaps C++98 )
MIT License
52 stars 4 forks source link

expected::operator*() for rvalue types should not be const #24

Closed rnburn closed 6 years ago

rnburn commented 6 years ago

See https://github.com/opentracing/opentracing-cpp/issues/64

martinmoene commented 6 years ago

Thanks Ryan,

It looks like 

constexpr value_type const && operator *() const &&

is missing, and 

constexpr value_type && operator *() const &&

is a mixture of both && methods.

You may have noticed I'm in the process of updating expected-lite for proposal p0323r5 in issue #20 where it hopefully also would have surfaced.

rnburn commented 6 years ago

Shouldn't there be a

 value_type && operator *() &&
martinmoene commented 6 years ago

Yes. Sorry to be have been too implicit, but that's what I also meant.