search

martinmoene / expected-lite

expected lite - Expected objects in C++11 and later in a single-file header-only library
Boost Software License 1.0
375 stars 34 forks source link

installation file structure #25

Closed rmorozov closed 5 years ago

rmorozov commented 5 years ago

Hello @martinmoene !

I want to file one more small issue.

When you want to perform make install the resulting file structure contains include directory several times.

how to reproduce

git clone https://github.com/martinmoene/expected-lite.git

cd expected-lite mkdir build cd build cmake -DCMAKE_INSTALL_PREFIX=pwd/install ../ make && make install

/Users/user/Source/expected-lite/build/install/include/include

that results in not working cmake config

I think you need to reconsider

install( DIRECTORY "${CMAKE_SOURCE_DIR}/include/" DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}" )

please pay attention to trailing / in "${CMAKE_SOURCE_DIR}/include/"

martinmoene commented 5 years ago

Thanks @rmorozov ,

I updated expected-lite, optional-lite, value_ptr-lite, variant-lite.

martinmoene commented 5 years ago

I think this one can be closed.