search

martinmoene / expected-lite

expected lite - Expected objects in C++11 and later in a single-file header-only library
Boost Software License 1.0
375 stars 34 forks source link

Fix version number contained in files and Release as v0.6.1 (was: Update Conan recipe for v0.6.0) #47

Closed martinmoene closed 2 years ago

martinmoene commented 2 years ago

Per PR #46

striezel commented 2 years ago

Update GitHub Release tag

If that means that the old tag is deleted and another commit is tagged as v0.6.0, then be aware that this may cause some inconsistencies among existing forks and working copies of expected-lite. More details about why re-tagging can be problematic can be read in the official Git documentation: https://git-scm.com/docs/git-tag#_on_re_tagging

Bottom line is:

Git does not update tags in existing repositories when doing a git fetch or git pull. So anyone who has checked out the repository will still have the old v0.6.0 tag unless the tag is updated manually in that person's repository checkout. So it might be easier to just create a new tag (e. g. v0.6.1) and use that one instead, possibly pointing out that v0.6.0 has the wrong version in the code and should not be used anymore.

martinmoene commented 2 years ago

Thanks @striezel for your informed suggestion to do a/the sensible thing :)

martinmoene commented 2 years ago

Released v0.6.1 here and on Conan Center, closing issue.