search

martinmoene / expected-lite

expected lite - Expected objects in C++11 and later in a single-file header-only library
Boost Software License 1.0
395 stars 35 forks source link

C++20 `__cplusplus value` #49

Open xavier2k6 opened 2 years ago

xavier2k6 commented 2 years ago

Shouldn't the __cplusplus value for C++20 be 202002L as per https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-170

https://github.com/martinmoene/expected-lite/blob/b33d22b294865cdb94e557d779a25ff2096ba618/include/nonstd/expected.hpp#L103

martinmoene commented 2 years ago

Thanks, sure :)

C++20 had been speculative:

https://github.com/martinmoene/expected-lite/blob/b33d22b294865cdb94e557d779a25ff2096ba618/include/nonstd/expected.hpp#L88

xavier2k6 commented 2 years ago

C++20 had been speculative:

https://github.com/martinmoene/expected-lite/blob/b33d22b294865cdb94e557d779a25ff2096ba618/include/nonstd/expected.hpp#L88

👍

Maybe, that can now be changed to (C++23 is speculative) if you make the other change/release. 🤣

xavier2k6 commented 2 years ago

@martinmoene I'm not sure if you are aware but the 2016 runner images have been removed from github actions..... only 2019/2022 are available now as of 31st July.......CI needs to be updated too.

martinmoene commented 2 years ago

@xavier2k6 ah, thanks, wasn't aware of it yet.

xavier2k6 commented 2 years ago

@martinmoene AppVeyor is still showing Queued? Will there be a 0.6.2 release anytime soon?

martinmoene commented 2 years ago

@xavier2k6 will try to release 0.6.2 today-ish.

martinmoene commented 2 years ago

@xavier2k6 expected-lite 0.6.2 released, conan update PR sent.

martinmoene commented 2 years ago

Dunno yet what'sup with AppVeyor...

xavier2k6 commented 2 years ago

I don't think I can help you with that......may have just been a glitch in the matrix! 🤣