search

martinmoene / ring-span-lite

ring-span lite - A C++yy-like ring_span type for C++98, C++11 and later in a single-file header-only library
Boost Software License 1.0
154 stars 12 forks source link

Attribution #8

Closed mattreecebentley closed 6 years ago

mattreecebentley commented 6 years ago

Source implementation is Guy Davidson and Arthur O'Dwyer, not solely arthur. The initial implementation was by Guy, and he is prrimary force behind the C++ proposal. Also, you might want to take a look at plf::colony for correcting compiler feature detection.

martinmoene commented 6 years ago

Also, you might want to take a look at plf::colony for correcting compiler feature detection.

@mattreecebentley Anything specific you noticed?

Quuxplusone commented 6 years ago

For the record, that source implementation Martin links to in the README is https://github.com/Quuxplusone/ring_view which is indeed 100% me. (As I recall, I started it as a proof-of-concept response to Guy's P0059R0, and then Guy adapted it into P0059R1.) Guy Davidson is indeed the primary author and motive force behind the WG21 proposal, and the newer implementation at https://github.com/WG21-SG14/SG14/blob/master/SG14/ring.h has contributions from both Guy and myself. But if Martin's talking about the source implementation hosted at https://github.com/Quuxplusone/ring_view with sole contributor @Quuxplusone... yeah, that's me. ;)

mattreecebentley commented 6 years ago

Ah ok cool - I didn't check the link and made the assumption the link was to the SG14 - no harm intended. Probably some credit still due to guy as he wrote the spec, but yeah.

@martinmoene If you take a look at the first section of any of the plf:: library headers, you'll find the compiler feature detection code. There's a bunch of cases where C++11 is specified as available but certain features are not - both for gcc and when other libraries are using libstdc++. Might be worth just copy-pasting that section then adapting to suit.

mattreecebentley commented 6 years ago

ps. Obviously boost config is the best reference for this, but it spralls across 100s of files. I'm only trying to adapt to the most common compilers.