search

martinmoene / span-lite

span lite - A C++20-like span for C++98, C++11 and later in a single-file header-only library
Boost Software License 1.0
495 stars 40 forks source link

Failed to build release 0.5.0 with gcc 5.4 and default `-std` setting #41

Closed flexferrum closed 4 years ago

flexferrum commented 4 years ago

Here is the diagnostic:

[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
In file included from /tmp/c3ipr/pr_66_1_0_0/test_package/test_package.cpp:1:0:
/tmp/c3ipr/pr_66_1_0_0/.conan/data/span-lite/0.5.0/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/nonstd/span.hpp: In function ‘void nonstd::span_lite::detail::throw_out_of_range(nonstd::span_lite::index_t, nonstd::span_lite::index_t)’:
/tmp/c3ipr/pr_66_1_0_0/.conan/data/span-lite/0.5.0/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/nonstd/span.hpp:614:11: error: ‘out_of_range’ is not a member of ‘std’
     throw std::out_of_range( "span::at(): index outside span" );

More details here: https://github.com/conan-io/conan-center-index/pull/66#issuecomment-533714103

flexferrum commented 4 years ago

I can prepare the corresponding pull request but the new release should be issued in order to successfully push it to the conan repository.

martinmoene commented 4 years ago

Hi @flexferrum , would you be willing to handle it (making you a contributor here)?

flexferrum commented 4 years ago

Yes, I would. But I can't make releases here.

martinmoene commented 4 years ago

Invitation sent, let's see how far it brings us.

flexferrum commented 4 years ago

Invitation accepted.

flexferrum commented 4 years ago

I've got the all desired access. Thanks!