search

martinmoene / string-view-lite

string_view lite - A C++17-like string_view for C++98, C++11 and later in a single-file header-only library
Boost Software License 1.0
422 stars 44 forks source link

added define to build without streams #42

Closed theShmoo closed 3 years ago

theShmoo commented 3 years ago

Hello! Thanks for your great library.

I need to use your library in an Intel SGX Enclave where we can't use standard streams (for security reasons).

In order to use your library I needed to exclude those lines from the header

martinmoene commented 3 years ago

Hi @theShmoo ,

Thanks for your input.

I'll likely implement these changes myself and perhaps use a configuration flag like nssv_CONFIG_NO_STREAM_INSERTION.

Files to update:

theShmoo commented 3 years ago

Thanks! Can I help you with anything?

martinmoene commented 3 years ago

Sure, if you like to update this PR into the direction of the suggestion above, that would certainly be of help :)

theShmoo commented 3 years ago

I updated the requested files 👍

martinmoene commented 3 years ago

Thanks @theShmoo ,

Looks good...

However, there's something I forgot to warn for: trailing double spaces in README.md's markdown are significant (see .editorconfig) and there are quite a lot of them. I'd appreciate it if you could you revert those to as they were before.

Thanks for your help.

theShmoo commented 3 years ago

Will do! Sorry for the auto formatting. Forgot to deactivate.

Martin Moene @.***> schrieb am Sa., 24. Apr. 2021, 14:01:

Thanks @theShmoo https://github.com/theShmoo ,

Looks good...

However, there's something I forgot to warn for: trailing double spaces in README.md's markdown are significant (see .editorconfig https://github.com/martinmoene/string-view-lite/blob/2abb8ead9c51a28c087109ef842754bc52537001/.editorconfig#L15) and there are quite a lot of them. I'd appreciate it if you could you revert those to as they were before.

Thanks for your help.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/martinmoene/string-view-lite/pull/42#issuecomment-826082471, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK7ANZZ7BJ5NT526JNRZNTTKKXKLANCNFSM43OOXAYQ .

theShmoo commented 3 years ago

Thank you very much for your support!

martinmoene commented 3 years ago

You're welcome, thank you too :)