search

martinohanlon / BlueDot

A zero boiler plate bluetooth remote
MIT License
145 stars 45 forks source link

Fixed the android app crash #190

Open avipars opened 2 months ago

avipars commented 2 months ago

In reference to issue #189 , I have prevented the crash and tested it on a Android 14 Galaxy S23 Device

avipars commented 2 months ago

I would love to put the android app in it's own repo and then get it published on f-droid, I think there are a lot of DIYers and makers that would find it useful there.

Let me know what you think!

martinohanlon commented 2 months ago

I won't be able to look at this until September.

I'm not against putting it in fdroid. Why does it need a separate repo?

avipars commented 2 months ago

I won't be able to look at this until September.

I'm not against putting it in fdroid. Why does it need a separate repo?

I am not super familiar with getting the app on f-droid, IIRC it needs to build the apk itself before publishing (and updates). @izzysoft might be able to tell us if its possible to build for f-droid from the nested clients folder

IzzySoft commented 2 months ago

Sorry @avipars – but I've absolutely no plan with apps built from Python. I know F-Droid can handle some with buildozer, but I was never involved with those.

avipars commented 2 months ago

Sorry @avipars – but I've absolutely no plan with apps built from Python. I know F-Droid can handle some with buildozer, but I was never involved with those.

The android app client is actually in java, and it sits in a subdirectory of the repo.

Would it be easier to add to f-drokd if the android app was in a separate repository?

IzzySoft commented 2 months ago

Should work as is – apologies, I've just looked at the languages indicated by Github. F-Droid recipe then would need subdir: clients/android/app. Question they'll raise: last release as well as last commit were more than 18 months ago, so point out its maintenance status then (I see it's still actively supported in the issues here; no more commits ≠ not maintained, could well just mean "mature and no changes needed" :wink:)