search

martinohmann / hcl-rs

HCL parsing and encoding libraries for rust with serde support
Apache License 2.0
121 stars 14 forks source link

fix(structure): handle absence of trailing newline in body #273

Closed martinohmann closed 1 year ago

martinohmann commented 1 year ago

Fixes #270 Closes #271

martinohmann commented 1 year ago

@denfren This is how I would fix #270, happy about feedback.

denfren commented 1 year ago

Looking good! My only thought is that i would change prefer_trailing_newline => prefer_omit_trailing_newline because omitting is the special case that is being requested.

martinohmann commented 1 year ago

Looking good! My only thought is that i would change prefer_trailing_newline => prefer_omit_trailing_newline because omitting is the special case that is being requested.

Yeah, that's better, I was about to copy that from your draft implementation. Will update the PR.

martinohmann commented 1 year ago

@denfren Updated