Please use annotated tags for releases, so versions show up correctly

martinpaljak / GlobalPlatformPro

🌐 🔐 Manage applets and keys on JavaCard-s like a pro

https://javacard.pro/globalplatform

GNU Lesser General Public License v3.0

699 stars 212 forks source link

Please use annotated tags for releases, so versions show up correctly #243

Closed nickray closed 4 years ago

nickray commented 4 years ago

Hey,

I packaged this for Arch Linux and noticed that the version shown via gp -V comes from git describe, which only uses annotated tags (the last such is 19.06.16).

I fix this by overwriting your tag with an annotated tag during packaging (https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=globalplatformpro#n22), so no urgency.

martinpaljak commented 4 years ago

Thanks! Fixed the release script (not in this repo)