martinpaljak / GlobalPlatformPro

🌐 🔐 Manage applets and keys on JavaCard-s like a pro
https://javacard.pro/globalplatform
GNU Lesser General Public License v3.0
713 stars 212 forks source link

Fix latest release links on the project website https://javacard.pro/globalplatform/ #303

Closed quapka closed 2 years ago

quapka commented 2 years ago

This issue is on https://javacard.pro/globalplatform/ not with GlobalPlatformPro directly.

Describe the bug

The linked website in the project description contains download links to the latest releases: https://github.com/martinpaljak/GlobalPlatformPro/releases/latest/gp.exe https://github.com/martinpaljak/GlobalPlatformPro/releases/latest/gp.jar

However, those links return 404 and Not Found.

Expected behavior

The valid links are (notice the extra /download/ part): https://github.com/martinpaljak/GlobalPlatformPro/releases/latest/download/gp.exe https://github.com/martinpaljak/GlobalPlatformPro/releases/latest/download/gp.jar

martinpaljak commented 2 years ago

Is that separate page worth the trouble at all? Maybe make it redirect to Github.. ?

quapka commented 2 years ago

Do you mean whether javacard.pro/globalplatform is worth the trouble? I am not the one making the call, but removing it and linking straight to GitHub sounds reasonable.

martinpaljak commented 2 years ago

Thanks for reporting, fixed!