search

martinpaljak / GlobalPlatformPro

🌐 🔐 Manage applets and keys on JavaCard-s like a pro
https://javacard.pro/globalplatform
GNU Lesser General Public License v3.0
713 stars 212 forks source link

Enforce explicit plugin versions #321

Closed Tillerino closed 1 year ago

Tillerino commented 1 year ago

Hi!

I recently bumped the Maven version in Nixpgks (https://github.com/NixOS/nixpkgs/pull/238746) and ran into some small but annoying manual effort w.r.t. the this package. The issue is that this package is packaged using the double invocation method which unfortunately breaks if not all maven plugin versions are set explicitly.

We're extending the documentation to prevent this (https://github.com/NixOS/nixpkgs/pull/238774), but I'm reaching out to fix the packages which have already been packaged. In this PR, we explicitly set the versions of a few plugins which hadn't had their versions set explicitly before and add a check with the enforcer plugin to make sure this won't accidentally break in the future.

Note that the exact versions of the plugins that you're using are not important to us and please do change them as you see fit. We only ask that you explicitly set the versions of all plugins so that downstream upgrades can run automatically.

Thank you.

(This was copy-pasta as I have a few repositories to go through. Please just ask if anything is unclear.)

bjornfor commented 1 year ago

Hi, what's the status of this PR? (Asking as a curious person who just sent a PR to update GlobalPlatformPro in nixpkgs: https://github.com/NixOS/nixpkgs/pull/250228.)

martinpaljak commented 1 year ago

I don't use nixos and can't comment. The restriction still applies?

martinpaljak commented 1 year ago

Sorry, misunderstood. Try next branch if possible for build. As some things (capfile module) got shifted around a new release is imminent as summer ends and fall commences

martinpaljak commented 1 year ago

This has been merged to master