search

martinpaljak / ant-javacard

Easy to use Ant task for building JavaCard applets (2.1.1 to 3.2.0)
https://javacard.pro
MIT License
202 stars 53 forks source link

Make strip option effective on library packages #80

Closed jkowalsk closed 1 year ago

jkowalsk commented 2 years ago

The strip option was not effective for library package (without applet defined).

Such cap file do not have "APPLET-INF/classes" directory. class files are instead stored in a package name dependent directory.

A basic test was added within tests-11.xml

This MR hopefully fixes it.

jkowalsk commented 2 years ago

Encountering some problems with my own project. I close this and eventually reopen once investigated

jkowalsk commented 2 years ago

After investigation problems where due to errors in my library/applet code leading to installation failure. All is fine when reverting to a working version. Therefore I reopen this.

Any comment welcome.

martinpaljak commented 2 years ago

Thanks for noticing!

martinpaljak commented 1 year ago

Hi! If you could give a manual spin to the ant-javacard.jar produced by the 'next' branch, would be awesome! I did check that it does clean up library cap-s for me at least.

martinpaljak commented 1 year ago

This should have been fixed by #86

jkowalsk commented 1 year ago

Hi, sorry for not answering, was on holiday. Tested and strip seems effective on both packages and applets, thanks.