Fix strncmp off-by-one in libumockdev-preload.c

martinpitt / umockdev

Mock hardware devices for creating unit tests and bug reporting

https://launchpad.net/umockdev

GNU Lesser General Public License v2.1

312 stars 58 forks source link

Fix strncmp off-by-one in libumockdev-preload.c #114

Closed disconnect3d closed 3 years ago

disconnect3d commented 3 years ago

The "/proc/" string is of len 6 instead of 5.

This was found with a "cstrnfinder" research and I haven't tested this change (more info https://twitter.com/disconnect3d_pl/status/1339757359896408065). Close this PR if this change is incorrect.

martinpitt commented 3 years ago

That fix looks correct, many thanks for spotting! Just the test runs were a complete disaster, apparently a lot has changed in the distros in the last 3 weeks.. I (mostly) fixed that in master. Can you please rebase/force-push your branch, so that the tests can run? Thanks!

martinpitt commented 3 years ago

@disconnect3d : I took the liberty to rebase your branch (as you allowed edits from maintainers). I also slightly adjusted the commit message. There are still some failures on debian-testing due to issue #115, these are unrelated.