umockdev: Only start socket server thread after creating FDs

martinpitt / umockdev

Mock hardware devices for creating unit tests and bug reporting

https://launchpad.net/umockdev

GNU Lesser General Public License v2.1

312 stars 58 forks source link

umockdev: Only start socket server thread after creating FDs #127

Closed benzea closed 3 years ago

benzea commented 3 years ago

Otherwise we may end up selecting an FD that does not exist, detecting EOF and the thread quits immediately. This causes random failures of the test suite.

A sample of a failure caused by this can be seen in https://github.com/martinpitt/umockdev/runs/2730392818?check_suite_focus=true#step:3:2025

FD is 0 here, but should obviously be non-zero.

EDIT: Update link; for some reason it ended up pointing to the later run.

martinpitt commented 3 years ago

@benzea FYI, I'm AFK until next Monday, in case you have more fixes queued.

benzea commented 3 years ago

Nope, nothing else for now. I am hoping to get the SPI stuff working, but that will need some other people poking it some more.