search

martinpitt / umockdev

Mock hardware devices for creating unit tests and bug reporting
https://launchpad.net/umockdev
GNU Lesser General Public License v2.1
314 stars 58 forks source link

tests: Hack Gentoo build #257

Closed martinpitt closed 2 weeks ago

martinpitt commented 3 weeks ago

About a month ago, vala fell out of umockdev's build dependencies. Explicitly install it.

@thesamesam @mattst88: Do you happen to know why valac does not get installed any more? It used to be part of 

ACCEPT_KEYWORDS="~*" emerge dev-util/umockdev --with-test-deps --onlydeps --getbinpkg

in the run-gentoo test script, but that doesn't happen any more. This was introduced by @mattst88 in ed29c0107ead81c1e460fff3884 and basically unchanged since then, other than the binary package optimization in commit 6a1d57a80a511c.

I can hack around it like in this PR by installing it explicitly, but that feels bad -- vala very much needs to be a build dependency of umockdev. Is that invocation wrong? Any help appreciated, thanks!

martinpitt commented 2 weeks ago

OK, timeout -- I'll keep Gentoo CI alive with that hack, and if it deteriotates further I'll drop it again.

(No offense meant, just want to keep stuff green, and take the urgency out)

thesamesam commented 2 weeks ago

Sorry, not ignoring you, just not had time to look at this properly yet -- the tab is open for me to come to! The workaround is fine.

martinpitt commented 2 weeks ago

@thesamesam Thanks! No worries, I'd just like to make the regular test runs green again, that turns this from "urgent" to "nice to have". I'm aware that we are all doing this in our spare time :grin:

Of course I'm happy to revise this hack later.