search

martinpl / tray-icons-reloaded

GNOME Shell extension which bring back Tray Icons to top panel, with additional features.
GNU General Public License v3.0
492 stars 29 forks source link

Icon images do not adjust with icon boxes #24

Open Dunemask opened 3 years ago

Dunemask commented 3 years ago

Gnome Version: 3.38.1 Expected Behavior: Icon images adjust with buttons for TrayIconsReloaded icons and menus Issue: Icon images do not adjust with icon boxes. Issue Duplicate?: Possible Duplicate of #21 Other extensions that may affect behavior: Dash to Panel, Arc Menu How to recreate:

  1. Use vanilla or modified settings (On both Dash to Panel and TrayIconsReloaded).
  2. Load up applications that will create Icons in TrayIconsReloaded .
  3. In the terminal notify-send "Hello World!" Until the notification tray extends to indicate multiple notifications.
  4. Hover over the Icons to see either no button, or a mismatched button.

  5. The boxes (Actual buttons) seem to adjust just fine, but the icon images do not. I have not had 100% results in recreating the issue (The worst type of bugs!!!). If you cannot recreate it yourself i'll do my best to catch it in the act! I have also experienced this with system suspension, locking the screen, and various other things that involve refreshing the gnome-shell. (This is why it may be a duplicate issue of #21) I'm pretty sure that an event just needs to be added to update the icon positions with the boxes but i'm not to familiar with how things work exactly in gnome.

The issue is not persistent, a good refresh, or restarting the extension seems to do the trick but it's kind of a pain.

robertmutke commented 3 years ago

I've got the same case with Dash to Panel. When both are on, the icons get misaligned.

Steps to reproduce:

  1. Open any app that has a tray icon - tadam!

When Tray Icons Reloaded or Panel to dash is restarted it gets fixed until new app is started or some icon is removed.

I've got the icons set to be in the center box next to the clock. The side of the clock does not matter.

Dunemask commented 3 years ago

This issue seems to be very similar if not the same as closed issue #19. While I have had the issue happen to me when opening a new application with an indicator, it's been relatively hit and miss. When browsing other similar extensions it seems that in working extensions, the extension listens for various signals when panel items are adjusted and calls a redraw (removing and replacing the icon) which simply seems absent, or is not being called correctly.

ghost commented 3 years ago

I have the same problem all the icons are misaligned, how do you fix it?

Dunemask commented 3 years ago

Currently i'm using a modified version of https://extensions.gnome.org/extension/1503/tray-icons/ I've modified the TIR(Tray-Icons-Reloaded Extension) css to match my TIR styling, and click button behaviors to match that of TIR but it doesn't have the same collapsing functionality. I haven't noticed any styling issues, but I miss the collapsability and easy to use interface TIR has. Unfortunately as it is, i'm unable to use TIR so I hope it get fixed soon!

ghost commented 3 years ago

Unfortunately as it is, i'm unable to use TIR so I hope it get fixed soon!

TrayIconsReloaded are all misaligned after the display sleeps. If I reboot gnome-shell then its all fine.

This needs to be fixed in source to work better with dash to panel and other extensions.

lgg commented 2 years ago

@MartinPL I confirm that issue still exist and I can reproduce it with just app reopening.

https://user-images.githubusercontent.com/12018713/159584483-21661425-f9f5-4b1e-9818-2dd1530201d6.mp4

lsb_release -a
LSB Version:    core-11.1.0ubuntu2-noarch:printing-11.1.0ubuntu2-noarch:security-11.1.0ubuntu2-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.4 LTS
Release:    20.04
Codename:   focal

gnome-shell --version
GNOME Shell 40.5

Extension version: 16