Remove show_all for GTK4 extensions preferences

martinpl / tray-icons-reloaded

GNOME Shell extension which bring back Tray Icons to top panel, with additional features.

GNU General Public License v3.0

492 stars 29 forks source link

Remove show_all for GTK4 extensions preferences #26

Closed uwueviee closed 3 years ago

uwueviee commented 3 years ago

The preferences panel for Tray Icons: Reloaded doesn't work in GNOME 40 as show_all() is no longer supported by GTK4 due to all widgets being visible by default. However this might break the preferences panel for < 40 users, I haven't been able to test that though.

From my testing, this is the only change required for running Tray Icons: Reloaded on GNOME 40.

martinpl commented 3 years ago

Yep it breaks under 40. I will pull this MR before 40 release. Thanks 👍

JoshStrobl commented 3 years ago

@MartinPL any chance we could get this merged in? GNOME 40 was released :slightly_smiling_face:

martinpl commented 3 years ago

I will make release after weekend :)

JoshStrobl commented 3 years ago

Thank you, it is much appreciated!