Closed daj102 closed 5 years ago
daj102
commented
5 years ago Hmmm - you know what, the more I dig, the more I find that "node1" is hard-coded in several other places (eg, Hadoop config files). Probably best for me to just accept node1 :-) I will revoke my Pull Request ...
martinprobson
commented
5 years ago OK, yes indeed node1 is hardcoded in a few places unfortunately.
daj102
commented
5 years ago Sorry for the confusion! By the way, I'm not very experienced with Git or GitHub and I cannot see a way to revoke my PR. I think you may have to do it because the PR is on your repo and you have rights. Can you kill/reject the pull request, or is there something I have to do? Sorry for causing you more work ...
--DJ
On Fri, Jan 4, 2019 at 8:47 AM Martin Robson notifications@github.com wrote:
OK, yes indeed node1 is hardcoded in a few places unfortunately.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/martinprobson/vagrant-hadoop-hive-spark/pull/17#issuecomment-451447678, or mute the thread https://github.com/notifications/unsubscribe-auth/AFEfa0nWDxsSQPOu6S3jO4hbFj_uohBaks5u_1tigaJpZM4Zob66 .
daj102
commented
5 years ago And I'm so rude - I've just realized I haven't thanked you for putting this up in the first place!!!! This was a great help getting up and running with Spark - I really appreciate you making so much work available :-) Thanks!
On Fri, Jan 4, 2019 at 8:49 AM Douglas Johnston daj102@gmail.com wrote:
Sorry for the confusion! By the way, I'm not very experienced with Git or GitHub and I cannot see a way to revoke my PR. I think you may have to do it because the PR is on your repo and you have rights. Can you kill/reject the pull request, or is there something I have to do? Sorry for causing you more work ...
--DJ
On Fri, Jan 4, 2019 at 8:47 AM Martin Robson notifications@github.com wrote:
OK, yes indeed node1 is hardcoded in a few places unfortunately.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/martinprobson/vagrant-hadoop-hive-spark/pull/17#issuecomment-451447678, or mute the thread https://github.com/notifications/unsubscribe-auth/AFEfa0nWDxsSQPOu6S3jO4hbFj_uohBaks5u_1tigaJpZM4Zob66 .
martinprobson
commented
5 years ago No worries, glad you found it helpful. I will revoke the PR.
Regards, Martin
On Fri, 4 Jan 2019 at 13:50, daj102 notifications@github.com wrote:
And I'm so rude - I've just realized I haven't thanked you for putting this up in the first place!!!! This was a great help getting up and running with Spark - I really appreciate you making so much work available :-) Thanks!
On Fri, Jan 4, 2019 at 8:49 AM Douglas Johnston daj102@gmail.com wrote:
Sorry for the confusion! By the way, I'm not very experienced with Git or GitHub and I cannot see a way to revoke my PR. I think you may have to do it because the PR is on your repo and you have rights. Can you kill/reject the pull request, or is there something I have to do? Sorry for causing you more work ...
--DJ
On Fri, Jan 4, 2019 at 8:47 AM Martin Robson notifications@github.com wrote:
OK, yes indeed node1 is hardcoded in a few places unfortunately.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/martinprobson/vagrant-hadoop-hive-spark/pull/17#issuecomment-451447678 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AFEfa0nWDxsSQPOu6S3jO4hbFj_uohBaks5u_1tigaJpZM4Zob66
.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/martinprobson/vagrant-hadoop-hive-spark/pull/17#issuecomment-451448568, or mute the thread https://github.com/notifications/unsubscribe-auth/ALiVd5ZVZdRtaJm3_teODOOgfTkWW00Nks5u_1xAgaJpZM4Zob66 .
martinprobson
commented
5 years ago closed
I noticed that the HDFS location of the Hive table is incorrect. While the table is created, it returns no rows because it is not reading from the right folder ... :-)