search

martinradev / gdb-pt-dump

MIT License
138 stars 26 forks source link

Fix the pid identification for multiple qemu-system instances belonging to other users #25

Closed Ex-Origin closed 1 year ago

Ex-Origin commented 1 year ago

When there are qemu-system instances belonging to other users, it may not obtain a PID.

martinradev commented 1 year ago

Thanks. I will review on Sunday evening.

martinradev commented 1 year ago

Thanks again and sorry for the delay.

I accept the changes but I have a suggestion for future contributions to projects in general: Write a longer commit which explains the issue, summarizes how it solves it and how it was tested.

This helps reviewers immediately understand the overall strategy for the commits and what issue is being solved. This also helps looking at the history of the project what issues existed and what commits solved them.