martinroob / ngx-i18nsupport

Some tooling to be used for Angular i18n workflows
MIT License
283 stars 69 forks source link

chore: dep upgrade and iface fixes #196

Open BernhardBehrendt opened 2 years ago

BernhardBehrendt commented 2 years ago

Hi Martin,

According to the Angular 13 Update I've tried to updated this libs dependencies and fixed some type safety issues. It's mostly building now but when it comes to tests (xlifmerge) it wont start and I actually think it might be a configuration issue only.

> jasmine ../../dist/ngx-i18nsupport/**/*spec.js

Error: Cannot find module '@ngx-i18nsupport/ngx-i18nsupport-lib'
Require stack:
- /Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/ngx-translate-extractor.js
- /Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/xliff-merge-parameters.js
- /Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/xliff-merge.js
- /Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/xlf12-merge.spec.js
- /usr/local/lib/node_modules/jasmine/lib/loader.js
- /usr/local/lib/node_modules/jasmine/lib/jasmine.js
- /usr/local/lib/node_modules/jasmine/bin/jasmine.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:93:18)
    at Object.<anonymous> (/Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/ngx-translate-extractor.js:4:31)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Module.require (internal/modules/cjs/loader.js:974:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/ngx-translate-extractor.js',
    '/Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/xliff-merge-parameters.js',
    '/Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/xliff-merge.js',
    '/Users/bernhard.behrendt/Coding/Sides/ngx-i18nsupport/dist/ngx-i18nsupport/src/xliffmerge/xlf12-merge.spec.js',
    '/usr/local/lib/node_modules/jasmine/lib/loader.js',
    '/usr/local/lib/node_modules/jasmine/lib/jasmine.js',
    '/usr/local/lib/node_modules/jasmine/bin/jasmine.js'
  ]
}

Will continue tmrw to investigate and if you might have a pro tipp :-) I would appreciate that very much.

Anyway thanks for that great lib.

BernhardBehrendt commented 2 years ago

Would you need anything more once it's working again to publish an update to npm as well?

Thanks in advance

Berni

dhcode commented 2 years ago

I have the issue from #197 too. So I checked out this PR. I tried

npm install
npm run buildall

But I get lots of TypeScript errors, I was not able to fix. I have node v14.170 and npm v7.24.2. However running npm install and npm run build in the projects/xliffmerge folder worked. If I use the built version in my project, I still get the error for xliffmerge: An unhandled exception occurred: NOT SUPPORTED: keyword "id", use "$id" for schema ID

timothyBrake commented 2 years ago

Merging this pull request would benefit almost everyone using localisation in Angular apps. Anyone knows if there is an official Angular merge tool available for i18n? Seems a no brainer to have in professional frameworks.

melcor76 commented 2 years ago

If @martinroob is the only one able to merge pull requests I wouldn't wait up to get this one approved. There hasn't been anything approved in 2-3 years in this repository and he hasn't been active in that long either.

wjentner commented 2 years ago

Is there any fork available that is maintained?

petya-v commented 2 years ago

Could we have this merged soon please?