Closed itsCryne closed 3 weeks ago
Perfect, will check these and add support for them
I don't have any experience with Qt and also only limited C++ knowledge but after having a look at the code it seems that we just need to add another line here in textfactory.cpp with
.replace(QSL("UT"), QSL("+0000"))
and add the following lines here
// Commented out patterns are already present
pat << QSL("d MMM yy HH:mm:ss");
pat << QSL("dd MMM yy HH:mm:ss");
pat << QSL("ddd, d MMM yy HH:mm:ss");
// pat << QSL("ddd, dd MMM yy HH:mm:ss");
pat << QSL("d MMM yy HH:mm");
pat << QSL("dd MMM yy HH:mm");
pat << QSL("ddd, d MMM yy HH:mm");
pat << QSL("ddd, dd MMM yy HH:mm");
// Four digit year
// Not valid per RFC822
// but valid per RFC2822
pat << QSL("d MMM yyyy HH:mm:ss");
pat << QSL("dd MMM yyyy HH:mm:ss");
// pat << QSL("ddd, d MMM yyyy HH:mm:ss");
// pat << QSL("ddd, dd MMM yyyy HH:mm:ss");
pat << QSL("d MMM yyyy HH:mm");
pat << QSL("dd MMM yyyy HH:mm");
pat << QSL("ddd, d MMM yyyy HH:mm");
// pat << QSL("ddd, dd MMM yyyy HH:mm");
If that seems correct, I could also submit a PR with those changes - but I guess it'd be faster/more convenient for you if you make them directly‽
Brief description of the issue
RSS Guard fails to recognize a date/time string if (e.g.) the day is only one digit or the timezone is
UT
although both are permitted by RFC822How to reproduce the bug?
What was the expected result?
The pubDate of all three items should be shown.
What actually happened?
Only the pubDate of the first item is shown correctly. For the other items, the date/time of the fetch is shown.![image](https://github.com/user-attachments/assets/c38b2256-10b1-4bba-8726-bcc2f0dab5f5)
Debug log
https://gist.github.com/itsCryne/2564a2a65d624626bafa46ae36c79fc7 (l. 372 & 373 show the error)
Operating system and version
RSS Guard
Version: 4.7.3 (built on Linux/x86_64)Revision: a4e20486b-lite
Build date: 7/26/24 4:34 AM
OS: Arch Linux
Qt: 6.7.2 (compiled against 6.7.2)