martinrotter / rssguard

Feed reader (and podcast player) which supports RSS/ATOM/JSON and many web-based feed services.
GNU General Public License v3.0
1.64k stars 125 forks source link

[BUG]: duplicate article filter assignment #1503

Closed seventyiris83 closed 1 month ago

seventyiris83 commented 1 month ago

Brief description of the issue

in a group of feeds where a filter (let's call it filter 1) is partially applied, rss guard re-applies filter 1 to the feeds that already had the filter applied when ticking the feed group (with the intention of applying filter 1 to all the feeds it wasn't applied to:

part 1: i tick the "Technology" feed group, resulting in all the feeds in the group to have "Test filter 1" applied once, no problem:

1 2

part 2: i add a new feed, "It's FOSS 2" to the "Technology" feed group, now "Test filter 1" is partially applied to the "Technology" group as expected:

3

part 3: i tick the "Technology" feed group with the intention of applying "Test filter 1" to "It's FOSS 2", it gets applied as expected:

4 5

part 4, the reason of this ticket: all the other feeds that previously had "Test fillter 1" applied to them now have a duplicate of it applied to them:

6 7

this only happens when ticket a feed group to quickly apply a filter to feeds in the group that don't have it applied. it does not happen when manually ticket a feed

following this logic, feeds could potentially have an unlimited amount of duplicate of feeds if repeated

How to reproduce the bug?

  1. have a feed group
  2. create a filter
  3. apply the filter to a feed group
  4. add a new feed to the same feed group
  5. tick the feed group to apply the filter to the new feed
  6. see that all the feeds that were there before the newly added one now have the same filter applied twice

What was the expected result?

only the new feed would have the article filter applied

What actually happened?

the new feed has the filter applied to it but all the previously existing feeds in the feed group also have the filter re-applied to them, resulting in duplicates

Debug log

N/A

Operating system and version

martinrotter commented 1 month ago

You were right, fixed.