martinrotter / rssguard

Feed reader (and podcast player) which supports RSS/ATOM/JSON and many web-based feed services.
GNU General Public License v3.0
1.56k stars 124 forks source link

[BUG], [MariaDB]: Failing to escape (quote, commas, Arabic/Urdu font, etc.) strings #579

Closed Starboy-Xo closed 2 years ago

Starboy-Xo commented 2 years ago

Brief description of the issue

A question mark is shown instead of Inverted commas and Arabic/Urdu font. Most probably these strings are not escaping properly.

How to reproduce the bug?

Self-explanatory:

What was the expected result?

The expected result was to see the proper strings.

What actually happened?

The following Image is self-explanatory: image

EDIT: MORE DATA URDU LANGUAGE: (Before clicking on URL Button in Browser ) image

URDU LANGUAGE: (After clicking on URL Button in Browser) image

Other information

Keep in mind that the website viewer also cannot escape the string unless you click on the "URL" then whole webpage is opened (which is the best feature in it).

Operating system and version

martinrotter commented 2 years ago

Post URL of such a feeds.

Starboy-Xo commented 2 years ago

I am using MariaDB: and this occurs (i guess when parsing the strings from) there

https://www.independent.co.uk/asia/china/china-xinjiang-intel-suppliers-letter-b1990563.html https://www.independent.co.uk/asia/china/china-daily/ancient-bronzes-china-buddha-bronzes-b1988610.html https://www.newsobserver.com/sports/spt-columns-blogs/luke-decock/article257187757.html https://www.fishstripes.com/2022/1/11/22877958/marlins-kyle-keller-npb-hanshin-tigers

I recently encountered a database crash too, But i am not confirm about the reason, so i am waiting for next crash. ~I wish i knew how to produce a debug log. I followed the documentation, it didnt help.~ Edit: I figured to produce a debug log now.

martinrotter commented 2 years ago

Not URLs of articles, I need URL of a feed, so that I can add it and test myself.

Starboy-Xo commented 2 years ago

Ah, apologies, here it is: http://feeds.feedburner.com/BBCNews_Urdu https://feeds.mcclatchy.com/newsobserver/stories

martinrotter commented 2 years ago

I cannot reproduce, tested with sqlite and mariadb.

image

martinrotter commented 2 years ago

Do you see same problems with SQLite DB backend?

Starboy-Xo commented 2 years ago

This happens while using MariaDB image

Close the application after fetching the feed using MariaDB, then re-open it, you may see these.

martinrotter commented 2 years ago

nothing, still same correct output

i would try newest mariadb version, especially if this happens for you only on mariadb backend.

Starboy-Xo commented 2 years ago

Just to let you know: I am using Xampp.

BTW, This is the result when you switch back to SQlite

image

martinrotter commented 2 years ago

then this is clearly problem with your version of mariadb server, you could try original mariadb?

https://mirror.nextlayer.at/mariadb/mariadb-10.6.5/winx64-packages/mariadb-10.6.5-winx64.zip

Starboy-Xo commented 2 years ago

image I tried it doesnt work.

Seems this is from my end.

martinrotter commented 2 years ago

it is just weird

martinrotter commented 2 years ago

cannot reproduce, closing, feel free to comment if any new things come up

martinrotter commented 2 years ago

This bug partially revelaed itself for me. Investigating. It seems to only trigger with Qt 5 (!) build of RSS Guard, not with Qt 6 build.

martinrotter commented 2 years ago

OK, found the bug upstream.

https://bugreports.qt.io/browse/QTBUG-95071

It is not fixed for Qt 5.15 but is for Qt 6. I will try to backport fix.

Starboy-Xo commented 2 years ago

Great that you found it.

martinrotter commented 2 years ago

OK my friend. I had to dig through Qt source code to find the problem.

I believe it is now fixed even for Qt 5.15+. Development build is building RN. Feel free to test.

martinrotter commented 2 years ago

Tested: image

Starboy-Xo commented 2 years ago

OK my friend. I had to dig through Qt source code to find the problem.

I believe it is now fixed even for Qt 5.15+. Development build is building RN. Feel free to test.

Many Thanks Brother!

Tested: image

Perfect!