martinrotter / rssguard

Feed reader (and podcast player) which supports RSS/ATOM/JSON and many web-based feed services.
GNU General Public License v3.0
1.54k stars 122 forks source link

[FR / Bug]: Skip Failing Feeds #870

Open zero77 opened 1 year ago

zero77 commented 1 year ago

Brief description of the feature request

I am using FreshRSS with multiple feeds and categories configured. I believe one or more of the feeds under some of the categories are failing but, i am unsure which one at the moment. Unless i update each working category manually it all fails to update and highlights everything in red.

So i can continue to test, can you please add support to skip failing feeds and continue to update the others.

Debug log: https://pastebin.com/raw/JZUvvaPz

martinrotter commented 1 year ago

should this setting be application-wide, or account-wide?

zero77 commented 1 year ago

application-wide would probably be better

martinrotter commented 1 year ago

I believe that account-wide would actually might be better.

OK, might implement this sometimes in future.

martinrotter commented 1 year ago

More questions. How exactly should this work? Once broken/unreachable feed is detected, it should be skipped forever, until app is restart? Or just skipped "several times"?

zero77 commented 1 year ago

At the moment i am using a FreshRSS account with RSS Guard, at least one of the feeds in this account has an issue and it causes the entire sync to stop after one or two feeds are updated.

It would be ideal if RSSGuard could update each feed separately each time and if one feed fails it stops and carries on with the others. Failing that, if one feed fails is should skip for maybe one hour and not, forever as i think that would cause less issues if it was only a one off failure.

martinrotter commented 1 year ago

It would be ideal if RSSGuard could update each feed separately each time and if one feed fails it stops and carries on with the others. Failing that, if one feed fails is should skip for maybe one hour and not, forever as i think that would cause less issues if it was only a one off failure.

Maybe I do not understand but if you "update" several feeds at once, then RSS Guard should update other feeds even if the one feed fails. This behavior is in the app for years now. Skipping previously failed feeds is not, but sync should not "stop" just for some failing feeds.

zero77 commented 1 year ago

I think this may be happening if you add individual feeds but, if you use an FreshRSS account it doesn't seem to happen, if one fails everything stops.

martinrotter commented 1 year ago

I think this may be happening if you add individual feeds but, if you use an FreshRSS account it doesn't seem to happen, if one fails everything stops.

Can you provide video evidence?

zero77 commented 1 year ago

There isn't much to see, that's why i am requesting this or something else to try and find out what's happening.

The first screen shot is after i have updated the first two categories separately and the bottom in red is the one that has at least one feed that keeps failing:

Before

The next screen shot is what happens when i try to update all feeds for that FreshRSS account, the white numbers are the total for that category:

After

martinrotter commented 1 year ago

in freshrss there are is some code which is executed before each individual feed is updated (this is specific stuff to greader API) and if that step fails, then all feeds fail automatically

this is not a bug

zero77 commented 1 year ago

Is there any way i can find out which is failing from within rssguard as i can't see any feeds failing in freshrss

martinrotter commented 1 year ago

When you hoover any failed feed with mouse, you should see the error message in tooltip.

zero77 commented 1 year ago

Thanks i didn't realise that was there, after it fails i am getting the below error with all feeds:

Auto-update status: uses global settings (42 minutes to next auto-fetch of articles) Active message filters: 0 Status: error (unknown error (InternalServerError))

martinrotter commented 1 year ago

error (unknown error (InternalServerError)

This is HTTP/500 error which is usually caused by upstream bug in the web software, FreshRSS in this case. I would check FreshRSS logs.

zero77 commented 1 year ago

Thanks, i will have a look