martinrotter / rssguard

Feed reader (and podcast player) which supports RSS/ATOM/JSON and many web-based feed services.
GNU General Public License v3.0
1.54k stars 123 forks source link

[FR]: Change colours in 'Test filter' for readability and accessibility #982

Open Mitecon opened 1 year ago

Mitecon commented 1 year ago

Brief description of the feature request

Whenever I'm working on a filter and I click the 'Test' button, certain articles may be highlighted with a green or red background. When this is done, it's quite hard to check visually because the background, especially the green one does not contrast well with the text.

I want to be able to see that my filter did, indeed, correctly match the articles I hoped it would. I would like to be able to scan matching articles for false-positives.

The problem is that the text is white and the green background is very light:

testing-filter-preview-green-is-hard-to-read

It's not so bad when the background is red:

testing-filter-preview-red-is-not-so-bad

It's worth noting that I use a dark theme (Breath Dark on KDE Plasma) but I do not know of a way to adjust this just for RSS Guard.

The possibilities are to change the text to black whenever there is a green background. I'm not sure if that's feasible, though. The other possibility is to simply change from a bright green to a less bright green. But then that would hurt people who used light themes that have black text.

Basically just to change things so that there's a definite contrast between both text and coloured background.

However, depending upon dark/light themes and accessibility settings, this might not be ideal. On a dark theme, text is light and on a light theme, text is dark. So there's no one-size-fits-all setting here.

So I propose to offer a user-customisable colour picker.

Mitecon commented 1 year ago

Never mind - I found it:

colours

Although, I would have to say that the wording does not help to explain which parts of the UI they affect.

'Errored items' is kind of fine, though it suggests a feed that isn't working at the moment. I've seen feeds with red text before so in my mind I connected it with that.

'OK-ish colour' does not really tell me that it means the background highlight for articles matching filter conditions.

In fact, I think I remember changing some things here when I first started using RSS Guard and I ended up with something unusable.

The little buttons to the right say 'Fetch colour from activated skin' when they should actually say something like 'Reset to default colour' or 'Reset to this skin's default colour'.

I'll leave this open for the moment because there's still a problem with the wording in places.

Other than that, what I have now is much better:

new-colours