martinrotter / textosaurus

Cross-platform text editor based on Qt and Scintilla.
GNU General Public License v3.0
284 stars 44 forks source link

Weird stuff in encryption method. #58

Closed martinrotter closed 5 years ago

martinrotter commented 5 years ago

Why do you check was_open so many times in CryptoFactory::decryptData function implementation?

If file.open(QIODevice::OpenModeFlag::ReadOnly) succeeds, you need to set was_open to true. I am not very familiar with Qt, so take my word with a grain of salt.

martinrotter commented 5 years ago

Will refactor these methods with openssl.