search

martinrusev / django-redis-sessions

Session backend for Django that stores sessions in a Redis database
BSD 3-Clause "New" or "Revised" License
495 stars 106 forks source link

Redis config from url #19

Closed jorilallo closed 7 years ago

jorilallo commented 11 years ago

It would be useful to parse Redis settings from an url (i.e. redis.from_url()). This would help with Heroku.

dghubble commented 11 years ago

I agree, and it would be nice if the README showed reading the Heroku url from the environment rather than just a hardcoded localhost example.

calvdee commented 11 years ago

Opened pull request here.

camilonova commented 11 years ago

@calvdee is merged now, seems this issue can be closed, btw you didn't add documentation on how to use it

hellysmile commented 11 years ago

@calvdee your redis from url and redis from unix socket tests is broken but realisation and idea is ok, you can check coverage of your tests. 1) your tests doesnt calls redis.StrictRedis.from_url and redis.StrictRedis with unix_socket_path 2) redis.StrictRedis.from_url requires redis schema not unix 3) redis_server.connection_pool.connection_kwargs with unix_socket_path doesnt contents host and port i have fixed it https://github.com/hellysmile/django-redis-sessions-fork and i have added preconfiguration from heroku ENV variables

calvdee commented 11 years ago

Okay, sorry should have spent more time with this.

camilonova commented 11 years ago

ok, so this can be safely closed?

calvdee commented 11 years ago

No I will need to resolve the issues @hellysmile pointed out above.