martinrusev / django-redis-sessions

Session backend for Django that stores sessions in a Redis database
BSD 3-Clause "New" or "Revised" License
495 stars 106 forks source link

dict and getattr o_O #50

Open liminspace opened 7 years ago

liminspace commented 7 years ago

SESSION_REDIS must be a dict. But in settings.py is written:

getattr(SESSION_REDIS, 'host', 'localhost')

This VERY BIG MISTAKE is a joke?

I see this bug was fixed but it hasn't released yet.

rhoog commented 7 years ago

@liminspace That is not the best way to phrase your request for a release.

I do hope it ends up pypi soonish as well though.

martinrusev commented 7 years ago

@rhoog will be in pypi soon enough. Wanted to test it for a week or two from git master

liminspace commented 7 years ago

As result I've moved to django-redis using django.contrib.sessions.backends.cache as SESSION_ENGINE. It works very good and has more functionality.