PyPi version not in sync with repo

martinrusev / django-redis-sessions

Session backend for Django that stores sessions in a Redis database

BSD 3-Clause "New" or "Revised" License

495 stars 106 forks source link

PyPi version not in sync with repo #8

Closed dlo closed 11 years ago

dlo commented 12 years ago

There have been a few major changes (e.g. tabs to spaces, inclusion of redis session setting, etc)--would love to see these on PyPi.

Thanks!

n3storm commented 12 years ago

Yes please, a problem with Django 1.4 is solved installing from repo insteado of pypi :)

Nick011 commented 12 years ago

Just ran into this problem. The 'save' function on the pypi version is missing the check for the redis version.

if redis.VERSION[0] >= 2:
    self.server.setex(self.get_real_stored_key(self._get_or_create_session_key()), self.get_expiry_age(), data)

lines 59 and 60 (and 61 for the 'else')

Will install from repo.

Edit:

I had another unrelated issue. So this may not actually be causing an error.

toudi commented 11 years ago

right now the major difference for me between pypi and the repo is the usage of redis unix socket path ;) but checked out the source and used the git repo instead :)

Natim commented 11 years ago

It seams very important to me to not forget to tag the commit before actualy send it to PyPi.

This is the workflow I am using:

Update VERSION number

Update CHANGELOG using commit messages:

git log --pretty=format:"* %s" ${LAST_VERSION}.. --
git commit -am "Release ${NEXT_VERSION}."
git tag -a "$NEXT_VERSION" -m "Release ${NEXT_VERSION}."

Upload version on PyPi: python setup.py sdist upload
- Reconfigure VERSION number with dev suffix
- Add CHANGELOG rule (unreleased)
  
  git commit -am "Back to development." git push origin master --tags

I am using this workflow on https://github.com/novagile/django-mail-factory/ for instance.