Closed hyenal closed 2 years ago
One comment about code style: please run make style
followed by make quality
on your code.
make style
applies black formatting and import sortingmake quality
checks black formatting, import sorting and also runs flake8
Another small suggestion: rename lr_schedules.py
to simply schedules.py
. To keep names short.
Looking good! Thanks for the PR.
Thanks :) It now pass the test but I still have to modify the examples to modify the schedule there :)
Looks good! Will merge once unit tests pass.
To avoid to over parametrise the learning rate schedule class I propose to make them serializable objects. This is also related to https://github.com/martinsbruveris/tensorflow-image-models/discussions/38