martinsbruveris / tensorflow-image-models

TensorFlow port of PyTorch Image Models (timm) - image models with pretrained weights.
https://tfimm.readthedocs.io/en/latest/
Apache License 2.0
286 stars 25 forks source link

Learning rate schedule is now a config class #44

Closed hyenal closed 2 years ago

hyenal commented 2 years ago

To avoid to over parametrise the learning rate schedule class I propose to make them serializable objects. This is also related to https://github.com/martinsbruveris/tensorflow-image-models/discussions/38

martinsbruveris commented 2 years ago

One comment about code style: please run make style followed by make quality on your code.

martinsbruveris commented 2 years ago

Another small suggestion: rename lr_schedules.py to simply schedules.py. To keep names short.

Looking good! Thanks for the PR.

hyenal commented 2 years ago

Thanks :) It now pass the test but I still have to modify the examples to modify the schedule there :)

martinsbruveris commented 2 years ago

Looks good! Will merge once unit tests pass.