Closed ThomasOrtiz closed 5 years ago
Hi,
thanks for the issue and the PR!
The only thing left to worry about is the removal of killPoints
, killPointsDelta
, winPoints
and winPointsDelta
from PC's participants attributes.
I think the easiest way to handle it would be to mark those fields as nullable in IParticipantAttributes
(and by consequence, mark the same fields as nullable in the class Participant
). This way we would keep the same code working for both PC and XBOX, otherwise we'd have to split Participant
objects according to the platform requested, and I don't really like that.
Something like this: https://gist.github.com/martinsileno/e84b6daa11f1469fd7ddb5dd6e913ea9.
If you have better ideas let me know!
Anyway, since they are marked as deprecated, according to their release process they will still be available for two weeks after the release.
I like the idea of keeping one participant object instead of separating them out -- keeps the models more maintainable for now.
I took your gist and updated my PR with your changes 👍
@martinsileno PUBG made another announcement today so I updated this issue to be generically for v6.0.0
and updated notes.
PR merged and version v1.5.0 released! 🎉
Only thing left is to add typing for seasonState
, as soon as we know its format.
PUBG API is updating their api to
v6.0.0
:Task List
steam
andkakao
toPlatformRegion
enum.gameModeStats
attributes: [bestRankPoints
,dailyWins
,rankPoints
,swimDistance
,weeklyWins
.gameModeStats
since Xbox and old-pc seasons still use them.SeasonStats
api call to handle new and old api formatmatches
endpoint to handle new api formatMajor Updates
New Ranking
XBOX
the original rating properties (as is) will still be available.PC
killPoints, winPoints, and their deltas will be deprecated forRankPoint
.New
Player Season-Stats
andMatches
:Matches:
Player's Season Stats:
rank
format for PC seasons before 10/3?Player by Id:
Source / Documentation