search

martint / jmxutils

Exporting JMX mbeans made easy
Apache License 2.0
173 stars 47 forks source link

A few simple improvements #2

Closed stevenschlansker closed 14 years ago

stevenschlansker commented 14 years ago

I made a few quickie improvements that you may consider testing and merging into mainline 1) Allow unexporting of MBeans easily 2) A default constructor that gets the platform MBeanServer, since 90% of the time that's what you write anyway

Let me know if you don't like any of the changes. Best, Steven Schlansker

martint commented 14 years ago

Thanks Steven!

I've already merged your first change and released a new version (1.6).

Regarding your second change, I like the basic idea, but I made a slight tweak. Instead of a default constructor, I added a static method "MBeanExporter.withPlatformMBeanServer()". That makes the intent of the method more explicit. This change will be in 1.7, as I didn't see your request until after I pushed 1.6.

Martin

stevenschlansker commented 14 years ago

That sounds great :) Thanks for the quick turnaround!