martinthomson / i-d-template

A template for IETF internet draft git repositories
Other
207 stars 182 forks source link

Mnot/334 #335

Closed mnot closed 2 years ago

mnot commented 2 years ago

Addressing #334.

TODO:

mnot commented 2 years ago

Arg, I just realised that requirements.txt and Gemfile will need to both be in the template so that they're available when the CI cache is inflated. @martinthomson is that odious? I can perhaps make them dot files, but they'll still be at the top-level index of the repo...

martinthomson commented 2 years ago

requirements.txt and Gemfile will need to both be in the template

I think that we can be dumber. As I mentioned, we can put a venv directory in the docker image and then copy it into place. It means that we don't get updates dynamically, we have to wait on a new image, but it means that we don't rely on the cache and all that. Because, yeah, putting new files into the template is more than a little odious, mostly because I don't think that we can get away with it without a lot more disruption.

mnot commented 2 years ago

Can the docker image put .gems and .venv in the top-level dir of the repo? If so that will^H^H^H^Hshould work.

mnot commented 2 years ago

Actually, we might be overthinking this. If the docker image installs the appropriate libraries in the system, the package cache should have copies available for the venv -- at least for Python. Not sure about Ruby.

mnot commented 2 years ago

This needs some testing, but I think it's getting close. Not sure about ruby package caching as per above.

mnot commented 2 years ago

still working on an issue in build-index.sh

mnot commented 2 years ago

/me crosses fingers