martinthomson / i-d-template

A template for IETF internet draft git repositories
Other
207 stars 182 forks source link

`svgcheck` 0.7.0 dropped `-X` #364

Closed larseggert closed 1 year ago

larseggert commented 1 year ago

See https://github.com/ietf-tools/svgcheck/pull/32.

snorp commented 1 year ago

Yeah, and in 0.7.1 there doesn't even seem to be an error printed for that? I get the following right now.

** Not using persistent HTTP -- cannot load such file -- net/http/persistent
**   To silence this message and get full speed, try:
**     gem install net-http-persistent
**   If this doesn't work, you can ignore this warning.
*** [svgcheck:] Traceback (most recent call last):
*** [svgcheck:]   File "/usr/local/google/home/jwillcox/tigress/lib/.venv/bin/svgcheck", line 8, in <module>
*** [svgcheck:]     sys.exit(main())
*** [svgcheck:]   File "/usr/local/google/home/jwillcox/tigress/lib/.venv/lib/python3.10/site-packages/svgcheck/run.py", line 122, in main
*** [svgcheck:]     parser = XmlRfcParser(source, verbose=options.verbose,
*** [svgcheck:]   File "/usr/local/google/home/jwillcox/tigress/lib/.venv/lib/python3.10/site-packages/xml2rfc/parser.py", line 500, in __init__
*** [svgcheck:]     with io.open(self.source, "rb", newline=None) as f:
*** [svgcheck:] FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/google/home/jwillcox/tigress/stdin'
*** could not create svg for "       ┌──────┐    ...
Error: Unable to parse the XML document: /dev/stdin

We should follow up with kramdown-rfc, but for now maybe we should just lock to the last known-good version, 0.6.2.

snorp commented 1 year ago

https://github.com/cabo/kramdown-rfc/issues/187

snorp commented 1 year ago

The error above is a separate regression in svgcheck. It has been worked around in the latest kramdown-rfc, but it looks like we need to rebuild the Docker images to get that. @martinthomson can you kick something?

martinthomson commented 1 year ago

Boot applied. Should be good in about 10 minutes, slightly longer if there is a build failure and I have to kick it again.