martinthomson / i-d-template

A template for IETF internet draft git repositories
Other
207 stars 182 forks source link

Consider checking a template-derived draft for substantial diff, to prevent PEBKAC-00 #372

Open LPardue opened 1 year ago

LPardue commented 1 year ago

Due to operator error, its possible to submit drafts before they are really ready. Solving that in the general case is a hard problem. However, its probably a lot easier to solve the case where someone checks out the template, does a load of work, and then in a rush tags git in a way that would produce a pretty embarrassing 00 draft*.

martinthomson commented 1 year ago

Best. Draft. Ever.

Frankly, I don’t really know what you would test for to avoid this problem. All the usual indicators of templateness are gone.

Maybe a datatracker change to show draft previews would help. Right now you can submit the draft without ever seeing it. WDYT?

rjsparks commented 1 year ago

@LPardue - would having a preview have caused you to pause in this particular case?

I'm not sure the template-like shape has been obfuscated so much that a diff warning couldn't be raised, Something like "This has only 3 sentences that are not boilerplate" (which you could do off the text version) raised as a warning might catch someone's eye more than a preview full of boilerplate would...